CSS hot reloading fix for platforms with urls that lack protocol and host prefix. #3649
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our internal runtime reports a getBundleUrl() value of "/". This breaks css reloading unless the comparison is changed to match if the link base url starts with the bundle url.
↪️ Pull Request
This fixes a bug that breaks an internal adobe runtime. Our runtime uses unusual URLs which fail with the current comparison.
If we change the comparison to pass if the link url starts with the bundle base URL this fixes our problem.
Since the purpose of the check is only to make sure that externally referenced css files are not reloaded, this does not break current browser behavior.
A hot reloaded local url will still not start with an external urls protocol host and port.
💻 Examples
A typical link url in our runtime is "/src.f69400ca.css?1571167198029/"
The bundle.getBaseURL() is "/"
🚨 Test instructions
Hot reloading of local css files should still work.
External css files links should not be updated on local change.
✔️ PR Todo