-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logger singleton #462
Logger singleton #462
Conversation
Codecov Report
@@ Coverage Diff @@
## master #462 +/- ##
==========================================
- Coverage 88.99% 88.92% -0.07%
==========================================
Files 62 62
Lines 1971 1986 +15
==========================================
+ Hits 1754 1766 +12
- Misses 217 220 +3
Continue to review full report at Codecov.
|
Sorry for the delay getting this in. I just cleaned up the IPC a little, so we aren't adding logging things to the Asset class. Instead, a proxy class is exported by the Logger in workers that sends IPC messages. That way you can use the normal logger "singleton" as usual but the messages will actually get sent to the main process. Seems to work well! |
@devongovett - clever idea with the proxy logger! 👍 |
@devongovett this is a breaking change (not sure if this project follows semver?). I suggest to put the logger back as a member to the bundler; so plugins that use bundler.logger do not break. |
* initial logger singleton * Clean up Logger IPC
* initial logger singleton * Clean up Logger IPC
Converts Logger into a singleton, so everything outside of bundler can use it.
Also created IPC for logger so that assets can send messages to the workerfarm, instead of overloading logger singleton.
After seeing #207 was too big of change and failing times and times again to fix the glitches with status i thought it be a better idea to just extract the singleton part of that PR and make a fresh clean new PR, without the conflicts, ...