Simplify diagnostics #5084
Merged
Simplify diagnostics #5084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Benchmark ResultsKitchen Sink ✅
Timings
Cold Bundles
Cached Bundles
React HackerNews ✅
Timings
Cold Bundles
Cached Bundles
AtlasKit Editor ✅
Timings
Cold Bundles
Cached Bundles
Three.js x4 🚨
Timings
Cold BundlesNo bundles found, this is probably a failed build... Cached BundlesNo bundles found, this is probably a failed build... |
We could simply keep the old name. |
|
@mischnic sure, I'll make it backwards compatible with the old name, I do believe it's more logical to change the name as it's an array of diagnostics now. |
|
I was rather thinking not adding |
# Conflicts: # packages/core/diagnostic/src/diagnostic.js
|
@mischnic got that, just realised this actually didn't change anything useful so changed all of it back. |
mischnic
approved these changes
Sep 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
This PR simplifies diagnostics, so codehighlights in diagnostics are always arrays and a ThrowableDiagnostic always takes in an array of diagnostics.
This is a breaking change, I can add a legacy diagnostic option back to ThrowableDiagnostic but I thought it would be better to just fail the plugins that rely on this option to ensure they update their plugins instead.
Closes #5078
✔️ PR Todo