Merge postcss-modules config #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamiebuilds
reviewed
Dec 7, 2017
src/transforms/postcss.js
Outdated
| @@ -24,12 +26,16 @@ async function getConfig(asset) { | |||
| } | |||
|
|
|||
| config = config || {}; | |||
| config.plugins = loadPlugins(config.plugins, asset.name); | |||
| const postcssModulesConfig = Object.assign(get(config.plugins, 'postcss-modules') || {}, { | |||
There was a problem hiding this comment.
Why not just config.plugins['postcss-modules']?
There was a problem hiding this comment.
@thejameskyle type safety
devongovett
reviewed
Dec 7, 2017
package.json
Outdated
| @@ -23,6 +23,8 @@ | |||
| "htmlnano": "^0.1.6", | |||
| "is-url": "^1.2.2", | |||
| "js-yaml": "^3.10.0", | |||
| "lodash.get": "^4.4.2", | |||
| "lodash.omit": "^4.5.0", | |||
There was a problem hiding this comment.
I'd rather avoid adding more dependencies if we can. omit could just be delete config.plugins['postcss-modules'], and get could be just be config.plugins['postcss-modules'].
|
@devongovett Now, just pure js |
devongovett
approved these changes
Dec 8, 2017
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
* Merge postcss-modules config * Use pure js instead of lodash * formatting
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
* Merge postcss-modules config * Use pure js instead of lodash * formatting
AGawrys
pushed a commit
that referenced
this pull request
Dec 7, 2020
…75) Add babel plugin to preload/prefetch import transform attributes into webpack magic comments Approved-by: Maia Teegarden
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.