Set ascii_only for swc emit #9243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
reviewed
Sep 14, 2023
fregante
reviewed
Sep 14, 2023
| swc_core::ecma::codegen::Config::default().with_target(swc_core::ecma::ast::EsVersion::Es5); | ||
| let config = swc_core::ecma::codegen::Config::default() | ||
| .with_target(swc_core::ecma::ast::EsVersion::Es5) | ||
| .with_ascii_only(true); |
There was a problem hiding this comment.
Does this also affect pre-existing unicode characters? E.g. does it turn '🙂' into '\uD83D\uDE42'?
There was a problem hiding this comment.
You're right. So I think we shouldn't actually do this.
This leads to the question: if Chrome allows 🙂, then why does it not allow some other unicode that is probably equally valid? (Unless it isn't valid which is what I asked about here)
There was a problem hiding this comment.
What changed in 2.7 that caused this issue in the first place?
There was a problem hiding this comment.
Probably a swc upgrade.
Input: ["\u0085", "\u200b", "\ufffe", "🙂"];
With 2.6.2: ["\x85", "\u200B", "\uFFFE", "\uD83D\uDE42"]
With 2.7.0: ["\x85", "", "�", "\uD83D\uDE42"]
With 2.9.0: ["\x85", "", "�", "\uD83D\uDE42"]
So your concern is already the case, it just doesn't happen for single-codepoint characters (or something like that)
does it turn
'🙂'into'\uD83D\uDE42'?
There was a problem hiding this comment.
So yeah, this PR would restore the behavior from 2.6.2, which is perfectly fine to me and hasn't bothered anyone since.
mischnic
force-pushed
the
emit-ascii-only
branch
from
c5e6f5f to
c4f1ce1
Compare
Benchmark ResultsKitchen Sink ✅
Timings
Cold Bundles
Cached Bundles
React HackerNews ✅
Timings
Cold Bundles
Cached BundlesNo bundle changes detected. AtlasKit Editor ✅
Timings
Cold Bundles
Cached BundlesNo bundle changes detected. Three.js ✅
Timings
Cold Bundles
Cached Bundles
|
devongovett
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8877
Don't replace unicode escape sequences with the corresponding unicode character, but leave that to the optimizer (which makes it possible to disable the replacement with a terserrc)
This was the case some time ago