support multiple workspaces #9265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- changed reporter project root to used process.cwd - only add client when workspace root matches project root
Benchmark ResultsKitchen Sink ✅
Timings
Cold BundlesNo bundle changes detected. Cached Bundles
React HackerNews ✅
Timings
Cold Bundles
Cached Bundles
AtlasKit Editor ✅
Timings
Cold Bundles
Cached Bundles
Three.js ✅
Timings
Cold BundlesNo bundle changes detected. Cached Bundles
|
celinanperalta
added a commit
that referenced
this pull request
Oct 23, 2023
* Add vscode workspace setting Disable js/ts validation for the workspace (packages that have .tsconfig should still work) * WIP: detect lsp server in reporter If the server isn't running, the reporter should do nothing. * Update todo doc * Add ideas to todo doc * Fix kitchen-sync example * support multiple workspaces (#9265) * WIP: lsp sentinel watcher * garbage * f * add initial sentinel check to watch * remove event emitter from reporter * update README, add reporter README * support multiple LSP clients - changed reporter project root to used process.cwd - only add client when workspace root matches project root * remove generated files * remove other generated files * move vscode-extension-TODO into extension dir * clean up * remove unused import --------- Co-authored-by: Celina Peralta <cperalta@atlassian.com> * remove examples changes * revert html example changes * move development info to CONTRIBUTING.md * Remove log Co-authored-by: Eric Eldredge <lettertwo@gmail.com> * Update packages/reporters/lsp-reporter/src/LspReporter.js Co-authored-by: Eric Eldredge <lettertwo@gmail.com> * Update packages/reporters/lsp-reporter/src/LspReporter.js Co-authored-by: Eric Eldredge <lettertwo@gmail.com> * Update packages/utils/parcel-lsp/src/LspServer.ts Co-authored-by: Eric Eldredge <lettertwo@gmail.com> * Update packages/utils/parcel-lsp/src/LspServer.ts Co-authored-by: Eric Eldredge <lettertwo@gmail.com> * Update packages/reporters/lsp-reporter/src/LspReporter.js Co-authored-by: Eric Eldredge <lettertwo@gmail.com> * Update packages/utils/parcel-lsp/src/LspServer.ts Co-authored-by: Eric Eldredge <lettertwo@gmail.com> * Update packages/reporters/lsp-reporter/src/LspReporter.js Co-authored-by: Eric Eldredge <lettertwo@gmail.com> * Update packages/utils/parcel-lsp/src/LspServer.ts Co-authored-by: Eric Eldredge <lettertwo@gmail.com> * add sentinel file cleanup * Apply suggestions from code review * linting --------- Co-authored-by: Eric Eldredge <lettertwo@gmail.com> Co-authored-by: Brian Tedder <6571474+imbrian@users.noreply.github.com> Co-authored-by: Niklas Mischkulnig <4586894+mischnic@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
💻 Examples
🚨 Test instructions
✔️ PR Todo