Fix dev packager global reference #9814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MonicaOlejniczak
force-pushed
the
molejniczak/global-dev
branch
2 times, most recently
from
5e3cc89 to
9115b1b
Compare
MonicaOlejniczak
force-pushed
the
molejniczak/global-dev
branch
from
9115b1b to
a54c7c7
Compare
MonicaOlejniczak
force-pushed
the
molejniczak/global-dev
branch
from
a54c7c7 to
85a1306
Compare
mattcompiles
approved these changes
Jun 20, 2024
mischnic
reviewed
Jun 24, 2024
| @@ -116,7 +116,7 @@ export class DevPackager { | |||
| let output = code || ''; | |||
| wrapped += | |||
| JSON.stringify(this.bundleGraph.getAssetPublicId(asset)) + | |||
| ':[function(require,module,exports) {\n' + | |||
| ':[function(require,module,exports,__globalThis) {\n' + | |||
There was a problem hiding this comment.
Where will that __globalThis be referenced?
There was a problem hiding this comment.
It is referenced here
I should have added it to the description, my bad :)
There was a problem hiding this comment.
that's referenced via arguments[3] though. Wouldn't this mean that if someone declared let __globalThis in their code they'd get an error stating that it is already defined? Doesn't look like this variable is used directly.
There was a problem hiding this comment.
Yes, that's correct. I opted for __globalThis since __global is more likely to be defined. I'd prefer to use globalThis directly instead of specifying an argument since it's well supported, but it would be inconsistent with the parcel runtime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
When running parcel without scope hoisting,
globalreferences are not passed through correctly in theDevPackagermodule. This results in runtime errors when any code directly usesglobal.without any checks of its existence sincevar global = arguments[3]is always undefined. These changes amend the pass through of the global object, so thatarguments[3]exists under a privately namespaced variable to prevent collisions with other constants named global.🚨 Test instructions
yarn test:integration