Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds logic to perpetually keep a send list up to date #519

Merged

Conversation

pushchris
Copy link
Contributor

Currently after you create a campaign it does not update the user the list will be going to even if you schedule the campaign for way in the future. The initial rationale behind this is that generating a send is expensive and it's hard to know when to cutoff a list since you could be sending to a disparate group of timezones.

This logic piggybacks off of the performance improvements introduced by rule caching to check for list additions and removals to know if we should re-check a users enrollment in a campaign. If the campaign has not yet started running and a users enrollment changes, we want to reflect that in the campaign by either adding or removing the user from the send. This should at best get you granularity up until the minute before a send and at worst up to 24hrs off depending on the timezone of the user and the other users you are sending to.

@pushchris pushchris changed the title Adds logic to perpetually keep a send list up to date [WIP] Adds logic to perpetually keep a send list up to date Oct 14, 2024
@leobarcellos
Copy link
Contributor

@pushchris If I understood it correctly, everytime a list is updated, it will trigger the updateCampaignSendEnrollment function, question is: how often lists are updated? Does it happen like from time to time on the worker instance or does it need a user to actually view the list on the interface?

@pushchris
Copy link
Contributor Author

Dynamic lists are updated in real time whenever either an identify or event is triggered for a given user

@pushchris pushchris force-pushed the feat/keep-campaign-send-list-up-to-date-until-its-running branch from 946f0e2 to 766929e Compare October 18, 2024 01:12
@pushchris pushchris changed the title [WIP] Adds logic to perpetually keep a send list up to date Adds logic to perpetually keep a send list up to date Oct 18, 2024
@pushchris pushchris marked this pull request as ready for review October 18, 2024 03:06
@pushchris pushchris merged commit b82f485 into main Oct 20, 2024
3 checks passed
@pushchris pushchris deleted the feat/keep-campaign-send-list-up-to-date-until-its-running branch October 20, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants