Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Code Matcher exemple to the documentation #628

Merged
merged 2 commits into from
Oct 27, 2024

Conversation

warquys
Copy link
Contributor

@warquys warquys commented Oct 27, 2024

Why this addition to the documentation?
I discovered that many developers using Transpiler did not know the existence of the codematcher. Adding exemple will add visibility to this tool.

@pardeike
Copy link
Owner

Great idea and contribution! May I ask you to move the last bit of code to the source file so it will compile checked files too?

Remove non use using, add HarmonyPatchAttribute on  other patchs, move snipet code exemple in the csharp file.
@pardeike
Copy link
Owner

pardeike commented Oct 27, 2024

Awesome. I asked ChatGPT for some structural review and maybe you want to adapt a few of the suggested changes. But you don't have to, I can pull it as it is: https://chatgpt.com/share/671e952c-c978-8009-a289-478fe54f2288

EDIT: I just learned that canvas based sessions don't share the document itself. Bummer.

@pardeike pardeike merged commit 7876a22 into pardeike:master Oct 27, 2024
25 of 27 checks passed
@warquys warquys deleted the Documentation branch October 27, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants