Skip to content
This repository has been archived by the owner on Feb 26, 2020. It is now read-only.

Add dapp-develop to built-in dapps #104

Merged
merged 5 commits into from
May 17, 2018
Merged

Add dapp-develop to built-in dapps #104

merged 5 commits into from
May 17, 2018

Conversation

axelchalon
Copy link
Contributor

Depends on parity-js/shared#5

package.json Outdated
@@ -65,6 +65,7 @@
"@parity/dapp-status": "js-dist-paritytech/dapp-status",
"@parity/dapp-tokendeploy": "parity-js/dapp-tokendeploy#0f6f9f2adb82c02e35056dba792a75e95f440cdd",
"@parity/dapp-tokenreg": "parity-js/dapp-tokenreg#9750a2c10a934f9ae0e6e7fd6fa5b9e25a7b0785",
"@parity/dapp-develop": "js-dist-paritytech/dapp-develop#3bb84c11bd40687586de6ec758759d9019805d4e",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm not mistaken packages should be sorted alphabetically.

@amaury1093
Copy link
Contributor

I think we can add this PR into this one too parity-js/dapp-wallet#7.

Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, dapp-develop loading correctly.

@amaury1093 amaury1093 added the A8-looksgood Pull request is reviewed well. label May 17, 2018
@amaury1093
Copy link
Contributor

Icon not loading, but can be fixed in a subsequent PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants