Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support for xcmv4 types #372

Merged
merged 9 commits into from
Feb 26, 2024
Merged

Conversation

marshacb
Copy link
Contributor

@marshacb marshacb commented Feb 21, 2024

Description

This PR adds support for relevant type changes that were introduced in XCMv4.

Changes

  • Added v4 as a supported XCM version
  • Added XCMv4 Asset type which no longer specifies Concrete as part of the AssetId
  • Updated Destination/Beneficiary type construction to reflect new array junction syntax
  • Added Westend -> AssetHub, AssetHub -> Westend and Asset Hub -> Collectives Xcmv4 examples
  • Updated relevant type construction in createXcmTypes
  • Added V4 test cases for each direction in createXcmTypes
  • Removed Multi from sortMultiAssetsAscending and dedupeMultiAssets

closes: #370

@marshacb marshacb changed the title fix: add support for xcmv4 types[WIP] fix: add support for xcmv4 types [WIP] Feb 21, 2024
@IkerAlus
Copy link
Contributor

can we add a bit context here to help reviewers, also link to the issue this is supposed to close?

add westend to assethub example
added Westend Asset Hub to Westend Collectives example
fixed beneficiary naming
@marshacb marshacb changed the title fix: add support for xcmv4 types [WIP] fix: add support for xcmv4 types Feb 23, 2024
@marshacb marshacb requested review from TarikGul and bee344 February 23, 2024 14:13
src/consts.ts Outdated Show resolved Hide resolved
Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing Job LGTM, just 1 small nit

@marshacb marshacb merged commit 0e5c545 into main Feb 26, 2024
6 checks passed
@Polkadot-Forum
Copy link

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/parity-tech-update-for-february/6630/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support XCM v4 new types
4 participants