fix: explicitly use passed in dest locations for bridgeTransfers #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s AssetHub locations rather than the relay chains location removed assumption that polkadots location should be intended as polkadot assethub added parseLocationStrToLocation util function updated SystemToBridge tests to explicitly provide AssetHub locations for polkadot kusama bridge cases
marshacb
changed the title
marshacb
changed the title
acatangiu
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
{"parents":"2","interior":{"X1":{"GlobalConsensus":"Polkadot"}}}) should be intended as Polkadot AssetHub ( e.g.{"parents":"2","interior":{"X2":[{"GlobalConsensus":"Polkadot"},{"Parachain":"1000"}]}}). Instead relies on the location value passed in{"parents":"2","interior":{"X2":[{"GlobalConsensus":"Polkadot"},{"Parachain":"1000"}]}}) rather than the relay chains locationSystemToBridgeintegration tests to explicitly provideAssetHublocations for p<>k bridge casesassetHubWETHToRhalaexample to atransferAssetsUsingTypeAndThencall in order to explicitly set AssetHub as the reserve locationparseLocationStrToLocationutil functioncloses: #407