This repository has been archived by the owner on Jun 30, 2022. It is now read-only.
Have asynchronous execution so that the bot stays responsive for new requests while executing commands #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joao-paulo-parity
force-pushed
the
async_exec
branch
from
6ebc87d
to
00b0656
Compare
|
closed in favor of https://github.com/paritytech/command-bot |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
Word of caution: we've faced issues related to overhead in the past (#47) although it's still inconclusive if asynchronous execution mattered for those cases. We should run the benchmarks after this branch is deployed and assure this change does not affect the measurements. If asynchronous execution does matter for those metrics, this implementation and the app's setup itself will have to be redesigned.
closes #68