Synchronize with Substrate #71
Conversation
|
Should be resynced once paritytech/substrate#9592 is merged to be able to run on rococo. |
runtime/src/lib.rs
Outdated
| pub BlockWeights: frame_system::limits::BlockWeights = frame_system::limits::BlockWeights | ||
| ::with_sensible_defaults(2 * WEIGHT_PER_SECOND, NORMAL_DISPATCH_RATIO); | ||
| pub BlockLength: frame_system::limits::BlockLength = frame_system::limits::BlockLength | ||
| ::max_with_normal_ratio(5 * 1024 * 1024, NORMAL_DISPATCH_RATIO); |
There was a problem hiding this comment.
I can't remember the exact reasoning (maybe @athei remembers), but BlockWeights and BlockLength definitions were copied from the default node-runtime.
There was a problem hiding this comment.
Cause the DeletionWeightLimit and DeletionQueueDepth depend on that to parameterize the lazy contract deletion. We should really push for solving this issue at the database level.
There was a problem hiding this comment.
Got it, I've added it back with a comment pointing this out.
There was a problem hiding this comment.
I'm okay getting this in now and doing another smaller update once paritytech/substrate#9592 is merged
| #!/bin/bash | ||
|
|
||
| # Helper script which outputs the diff to Substrate's `node-template`. | ||
| SUBSTRATE_DIR=${SUBSTRATE_DIR:-~/projects/substrate} |
There was a problem hiding this comment.
I'd change this to be user provided since not everyone has their Substrate build in ~/projects/substrate 😉
There was a problem hiding this comment.
It already does this, this is just the default. The bash syntax is ${VAR:-default}.
So you can invoke the script with SUBSTRATE_DIR=/tmp/substrate substrate-diff.sh.
There was a problem hiding this comment.
Yeah, but imo it's not a great default. Having no default and enforcing that users point to their Substrate folder would be better
I've also reduced the
diffto the Substratenode-template, hence why there are some non-functional changes. This makes it easier to keep ourcanvas-nodein sync.