Convert Node to Parachain #73

HCastano · 2021-08-30T22:32:07Z

This is a WIP attempt to turn the canvas-node into a Cumulus based parachain. Right now
I'm using the substrate-parachain-template as a reference.

There is a problem with this though. The substrate-parachain-template is using
Substrate branch polkadot-v0.9.9 and the canvas-node needs to follow a fairly recent
version of Substrate in order for the contract functionality to work.

We've worked around this by creating a branch based off Substrate's polkadot-v0.9.9
which cherry-picks the pallet-contracts commit which we need. We've then used this
Substrate branch in BEEFY, Polkadot, and Cumulus.

One thing we can do is wait for Substrate's polkadot-v0.9.10 branch to be cut (which
should happen this week) and that would make it a bit easier to keep the right
dependencies synced up across the three repos.

It looks like the polkadot-v0.9.10 won't have the required changes for us. While the custom
branches work for now, we should really move away from them quickly once polkadot-v0.9.11
is cut.

…late`

cmichi · 2021-09-01T14:54:44Z

Wdyt about this?

The parachain-template is currently synced to polkadot-v0.9.9.
My understanding is that we need only this commit for supporting a contracts parachain: paritytech/substrate@bd69793.
We could create a Substrate branch which we branch off Substrate's polkadot-v0.9.9 branch. Maybe something like $name-polkadot-v0.9.9-with-contracts-support.
Then we could cherry-pick that one commit to our branch and use that branch in our node's Cargo.toml. The changes in that commit also extend to some other parts of the Substrate codebase, but on first glance it doesn't look problematic.
After polkadot-v0.9.10 is released and the parachain-template has been updated, we migrate those dependencies.

HCastano · 2021-09-01T22:28:25Z

The cherry-picked branch sounds like a good idea! We need to make sure that Cumulus and Polkadot are also up to date. This means we need to:

Create $name-polkadot-v0.9.9-with-contracts-support branch on Substrate
Create a name-polkadot-v0.9.9-... branch on Cumulus which uses the Substrate name-polkadot-v0.9.9-... branch
Create a name-polkadot-v0.9.9-... branch on Polkadot which uses the Substrate name-polkadot-v0.9.9-... branch
Finally, we can use the name-polkadot-v0.9.9-... in the canvas-node and hope everything works out 🤞

Also updated some fields to point to the relevant `canvas-node` resources.

node/src/rpc.rs

node/src/chain_spec.rs

node/src/service.rs

The reason that my code wouldn't compile was that there was a mismatch in the `Block` type being used by the service and the RPC.

HCastano · 2021-09-03T20:13:51Z

@TriplEight Hey Denis, do you know why the Linux pipeline is failing? The error is:

cp: cannot stat '/ci-cache/canvas-node/targets/73/build-linux/release/canvas': No such file or directory

nuke-web3 · 2021-09-03T21:03:22Z

Hey guys - I am sure you are aware of the limitations on the PoV size that might block you here, right?
paritytech/substrate#9354

I also am under the impression that other optimizations will be needed and (possibly) some work on the sand-boxing upstream for the contracts pallet in the context of parachains/PoV that are missing.

Happy to be wrong here, many people are looking for contract enabled parachains 😁

athei

I recommend setting all of these to zero to prevent eviction of contracts:

type TombstoneDeposit = TombstoneDeposit;
type DepositPerContract = DepositPerContract;
type DepositPerStorageByte = DepositPerStorageByte;
type DepositPerStorageItem = DepositPerStorageItem;
type RentFraction = RentFraction;
type SurchargeReward = SurchargeReward;

Also we should set resolver = "2" in our root Cargo.toml. Substrate does that, too.

node/Cargo.toml

node/src/chain_spec.rs

node/Cargo.toml

runtime/Cargo.toml

athei

Requesting changes because we shouldn't enable unstable interface by default.

riusricardo

Looks good so far.

node/src/chain_spec.rs

riusricardo · 2021-09-06T10:50:07Z

runtime/src/lib.rs

+	// One XCM operation is 1_000_000 weight - almost certainly a conservative estimate.
+	pub UnitWeightCost: Weight = 1_000_000;
+	// One UNIT buys 1 second of weight.
+	pub const WeightPrice: (MultiLocation, u128) = (X1(Parent), UNIT);


The constant WeightPrice is unused.

It comes from the parachain template (and is also unused there). I'm gonna leave it here just to keep the diff smaller, but it should be addressed upstream next time the template gets updated

I think this pulls in some updated dependencies which breaks the build.

This is for BEEFY, Polkadot, and Cumulus

athei

Apart from the runtime configuration it looks good to me.

runtime/src/lib.rs

Co-authored-by: Alexander Theißen <alex.theissen@me.com>

We'll be creating an updated config later on.

cmichi · 2021-09-07T05:44:23Z

node/src/chain_spec.rs

+	// Give your base currency a unit name and decimal places
+	let mut properties = sc_chain_spec::Properties::new();
+	properties.insert("tokenSymbol".into(), "CAN".into());
+	properties.insert("tokenDecimals".into(), 12.into());


Ah, we want to use the relay chain currency here and not have a separate one. Does anybody know if it's sufficient to just remove the properties altogether?

We need to keep the properties here and align them with the relay-chain we'll connect to.
E.g. Kusama

let mut properties = sc_chain_spec::Properties::new(); properties.insert("tokenSymbol".into(), "KSM".into()); properties.insert("tokenDecimals".into(), 12.into());

We'll also need to do native token teleport in order to use the relay-chain token.

This also means we do not need our own faucet but can just point users to the rococo faucet?

This also means we do not need our own faucet but can just point users to the rococo faucet?

That's a good point, hmm, is it even possible to have dedicated parachain endowed accounts then? 🤔

HCastano added 3 commits August 30, 2021 14:40

Update runtime to match that of the substrate-parachain-template

29f08ab

Update runtime TOML file to match that from `substrate-parachain-temp…

d50cef9

…late`

Add some fixes for master branch code

993d62e

HCastano changed the title ~~Convern Node to Parachain~~ Convert Node to Parachain Aug 30, 2021

cmichi mentioned this pull request Sep 1, 2021

Add initial repository content paritytech/substrate-contracts-node#1

Merged

HCastano added 10 commits September 2, 2021 12:05

Use patched dependencies for Substrate, Polkadot, and Cumulus

53ae1fe

Update runtime after downgrading Substrate deps

ee1a336

Copy service file over from substrate-parachain-template

99237f0

Copy CLI file over from substrate-parachain-template

aa89512

Copy Command file over from substrate-parachain-template

56d3320

Also updated some fields to point to the relevant `canvas-node` resources.

Copy ChainSpec file over from substrate-parachain-template

fc0a457

Update ChainSpec file to be slightly more Canvas node specific

b1d8818

Add lib file to node

674b98c

Get RPC extension file compiling

de3d824

Try adding RPC to Cumulus service

3c3c87f

HCastano commented Sep 2, 2021

View reviewed changes

node/src/rpc.rs Outdated Show resolved Hide resolved

cmichi reviewed Sep 3, 2021

View reviewed changes

node/src/chain_spec.rs Outdated Show resolved Hide resolved

cmichi reviewed Sep 3, 2021

View reviewed changes

node/src/chain_spec.rs Outdated Show resolved Hide resolved

cmichi reviewed Sep 3, 2021

View reviewed changes

node/src/service.rs Outdated Show resolved Hide resolved

HCastano added 7 commits September 3, 2021 13:53

Use opaque types in RPC

b05ecb3

The reason that my code wouldn't compile was that there was a mismatch in the `Block` type being used by the service and the RPC.

Hook up contracts RPC

a15d653

Copy rustfmt config from substrate-parachain-template

98de855

Format repo

be314ae

Remove old monetary units

570f458

Address most remaining TODO items

a7a50fb

Add missing license header

9ac79fe

athei reviewed Sep 6, 2021

View reviewed changes

node/Cargo.toml Outdated Show resolved Hide resolved

node/src/chain_spec.rs Show resolved Hide resolved

node/Cargo.toml Outdated Show resolved Hide resolved

node/Cargo.toml Outdated Show resolved Hide resolved

runtime/Cargo.toml Outdated Show resolved Hide resolved

athei suggested changes Sep 6, 2021

View reviewed changes

riusricardo reviewed Sep 6, 2021

View reviewed changes

HCastano added 13 commits September 6, 2021 11:09

Change binary name back to canvas

aac2f41

Use less sketchy Substrate branch name

ecd8f97

Remove default node feature

c04743a

Add path to binary section

a7c4e9b

Use experimental Cargo resolver

0a59241

Revert Substrate branch change

79e7169

I think this pulls in some updated dependencies which breaks the build.

Clean up contracts related imports in TOML file

a11b57a

Set pallet-contracts state rent related params to zero

0254de3

Don't use unstable contract features by default

41c83e8

Update Substrate dependencies in README

3edfdd4

Update Substrate branch name

08ce160

Update GitHub dependency references

e24d0b5

This is for BEEFY, Polkadot, and Cumulus

Update ChainType and chain names

6d157e3

HCastano marked this pull request as ready for review September 6, 2021 22:21

athei approved these changes Sep 6, 2021

View reviewed changes

runtime/src/lib.rs Outdated Show resolved Hide resolved

runtime/src/lib.rs Outdated Show resolved Hide resolved

HCastano and others added 3 commits September 6, 2021 17:42

Update contract-pallet constants

693de48

Co-authored-by: Alexander Theißen <alex.theissen@me.com>

Remove testnet-1.json file

521e940

We'll be creating an updated config later on.

Attach issue number to TODO comment

aee43ca

HCastano requested review from riusricardo and cmichi September 6, 2021 22:50

Minor readme fix

c03a3c9

cmichi reviewed Sep 7, 2021

View reviewed changes

Remove outdated usage info

c545540

riusricardo approved these changes Sep 7, 2021

View reviewed changes

cmichi merged commit 38effce into master Sep 7, 2021

cmichi deleted the hc-add-parachain-template branch September 7, 2021 08:39

HCastano mentioned this pull request Sep 22, 2021

Parachain #30

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Convert Node to Parachain #73

Convert Node to Parachain #73

HCastano commented Aug 30, 2021 •

edited

Loading

cmichi commented Sep 1, 2021 •

edited

Loading

HCastano commented Sep 1, 2021

HCastano commented Sep 3, 2021

nuke-web3 commented Sep 3, 2021

athei left a comment

athei left a comment

riusricardo left a comment

riusricardo Sep 6, 2021

HCastano Sep 6, 2021

athei left a comment

cmichi Sep 7, 2021

riusricardo Sep 7, 2021

riusricardo Sep 7, 2021

athei Sep 7, 2021

cmichi Sep 7, 2021

Convert Node to Parachain #73

Convert Node to Parachain #73

Conversation

HCastano commented Aug 30, 2021 • edited Loading

cmichi commented Sep 1, 2021 • edited Loading

HCastano commented Sep 1, 2021

HCastano commented Sep 3, 2021

nuke-web3 commented Sep 3, 2021

athei left a comment

Choose a reason for hiding this comment

athei left a comment

Choose a reason for hiding this comment

riusricardo left a comment

Choose a reason for hiding this comment

riusricardo Sep 6, 2021

Choose a reason for hiding this comment

HCastano Sep 6, 2021

Choose a reason for hiding this comment

athei left a comment

Choose a reason for hiding this comment

cmichi Sep 7, 2021

Choose a reason for hiding this comment

riusricardo Sep 7, 2021

Choose a reason for hiding this comment

riusricardo Sep 7, 2021

Choose a reason for hiding this comment

athei Sep 7, 2021

Choose a reason for hiding this comment

cmichi Sep 7, 2021

Choose a reason for hiding this comment

HCastano commented Aug 30, 2021 •

edited

Loading

cmichi commented Sep 1, 2021 •

edited

Loading