-
Notifications
You must be signed in to change notification settings - Fork 0
feat: wallet connect and initial multisig creation ui #16
Conversation
karl-kallavus
commented
Jan 30, 2023
•
edited
Loading
edited
- wallet connect
- sidebar
- twind configuration
- headlessui preact setup
- basic multisig creation page (still WIP)
Also, would be nice to include a screenshot in PR of a design/view/UI-part that the PR is related to, maybe figma link too? |
This PR is getting bigger with new features commits, how about merging it after reviews? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are still a few things before we can call this production ready.
- when navigating between routes the wallet connection is retried and it shouldn't be. can we make the topbar not lose state on route change? at the moment it's pretty fragile, connects disconnects depending on which route i'm visiting and how fast i'm clicking. there is sometimes an error
chunk-3MEZAT5T.js:4 Uncaught (in promise) NotInstalledError: Refresh the browser if Polkadot.js is already installed.
- after i click on a wallet to connect, the button text still says "connect wallet." it should select the first account in the list or display "some placeholder text" if there are no acounts in the extension.
The wallet connect functionality seems to be stable now. A few minor changes still:
Please open some follow up issues:
|
3264203
to
a271142
Compare
@statictype, please re-review
|
sorry for the long review, but this is what you get for creating long PRs 🙂 |