Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Not charging for proof weight #2322

Closed
xlc opened this issue Mar 15, 2023 · 5 comments · Fixed by #2326
Closed

Not charging for proof weight #2322

xlc opened this issue Mar 15, 2023 · 5 comments · Fixed by #2326

Comments

@xlc
Copy link
Contributor

xlc commented Mar 15, 2023

cumulus/parachains/runtimes/assets/statemint/src/constants.rs

Line 64 in 6688750

let q = 100 * Balance::from(ExtrinsicBaseWeight::get().ref_time());

cumulus/parachains/runtimes/assets/statemint/src/xcm_config.rs

Lines 292 to 293 in 6688750

type Trader = (
UsingComponents<WeightToFee, DotLocation, AccountId, Balances, ToStakingPot<Runtime>>,

@xlc xlc mentioned this issue Mar 15, 2023
Open
@joepetrowski
Copy link
Contributor

Do you mean proof size?

@xlc
Copy link
Contributor Author

xlc commented Mar 15, 2023

Yes. Proof size in weight.

@joepetrowski
Copy link
Contributor

AFAIK the migration to weights v2 is not complete, @ggwpez can you comment on the plan to address this?

@ggwpez
Copy link
Member

ggwpez commented Mar 15, 2023 •
edited
Loading

Ah right - did not realize that this would take effect without editing Cumulus templates, since we use the builtin template here.
I will open an MR to do a trivial charging implementation.

@bkontur
Copy link
Contributor

bkontur commented Mar 15, 2023

@ggwpez
do you mean this template, which is still using from_ref_time https://github.com/paritytech/cumulus/blob/master/templates/xcm-bench-template.hbs#L49 ?

This was referenced Mar 15, 2023
Merged
Merged
@ggwpez ggwpez mentioned this issue Mar 17, 2023
Merged
This was referenced May 10, 2023
Closed
Closed
bkontur added a commit that referenced this issue Aug 10, 2023
@bkontur
Squashed 'bridges/' changes from 0417308a48..278119fec2
292849e 
278119fec2 Grandpa: Store the authority set changes (#2336) (#2337)
19f9c8ffdb remove message sender origin (#2322)
3c7c271d2e GRANDPA module: store accepted justifications (#2298) (#2301)
fb7d12e793 GRANDPA justifications: equivocation detection primitives (#2295) (#2297)
d03a2ed450 More backports from Cumulus subtree to polkadot-staging (#2283)
3c4ada921b Update dependecies (#2277) (#2281)
3e195c9e76 GRANDPA: optimize votes_ancestries when needed (#2262) (#2264)
7065bbabc6 Implement RuntimeDebug for GrandpaJustification (#2254)
8c9e59bcbc Define generate_grandpa_key_ownership_proof() (#2247) (#2248)
0b46956df7 Deduplicate Grandpa consensus log reading logic (#2245) (#2246)
96c9701710 Fix deps from Cumulus (#2244)

git-subtree-dir: bridges
git-subtree-split: 278119fec2b45990cf1271999b0c21befe7003d9
paritytech-processbot bot pushed a commit that referenced this issue Aug 10, 2023
@bkontur
Bridges subtree sync (#2991)
934d029 
* Squashed 'bridges/' changes from 0417308a48..278119fec2

278119fec2 Grandpa: Store the authority set changes (#2336) (#2337)
19f9c8ffdb remove message sender origin (#2322)
3c7c271d2e GRANDPA module: store accepted justifications (#2298) (#2301)
fb7d12e793 GRANDPA justifications: equivocation detection primitives (#2295) (#2297)
d03a2ed450 More backports from Cumulus subtree to polkadot-staging (#2283)
3c4ada921b Update dependecies (#2277) (#2281)
3e195c9e76 GRANDPA: optimize votes_ancestries when needed (#2262) (#2264)
7065bbabc6 Implement RuntimeDebug for GrandpaJustification (#2254)
8c9e59bcbc Define generate_grandpa_key_ownership_proof() (#2247) (#2248)
0b46956df7 Deduplicate Grandpa consensus log reading logic (#2245) (#2246)
96c9701710 Fix deps from Cumulus (#2244)

git-subtree-dir: bridges
git-subtree-split: 278119fec2b45990cf1271999b0c21befe7003d9

* Subtree update

* Squashed 'bridges/' changes from 278119fec2..edf33a2c85

edf33a2c85 Backport fix (for wasm `std` env) (#2339)

git-subtree-dir: bridges
git-subtree-split: edf33a2c85399d366e008228f2d9e63e8a492d95
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Parachains should charge for proof size weight paritytech/cumulus
4 participants
@xlc @bkontur @ggwpez @joepetrowski