Align versions for starters runtimes

[bkontur]

No description provided.

[NachoPal]

You forgot to bump penpal (only the spec_version)

[bkchr]

Why bump them? They are thought as some sort of think that people copy as a starter. They don't really need these version numbers?

[NachoPal]

Why bump them? They are thought as some sort of think that people copy as a starter. They don't really need these version numbers?

To indicate they are based on substrate and polkadot v0.9.27

[gilescope]

If we are going to bump all the version numbers every time with cumulus then why not have diener do it automatically when it brings in a new polkadot release? Personally I'd move to close this PR. I don't think we should be auto bumping all of them.

[bkontur]

@bkchr @gilescope @NachoPal
before this PR,
starters/seedling had just bumped spec_version and not Cargo.toml version
starters/shell was not bumped neither spec_version nor Cargo.toml version
testing/rococo-parachain had bumped both spec_version and Cargo.toml version
starters/shell was not bumped neither spec_version nor Cargo.toml version

so it is kind of really unclear, what should be bumped or not,
I would maybe prefer to do this in one way and not partially.

so, how do we want it finally?
bump spec_version and Cargo.toml for every runtime in release or no?

[chevdor]

I see no reason to bump those.

First of all, the runtimes did not change.

Second, this is not a one shot bump. If we start bumping this now, we need to keep bumping everytime, all those runtimes, that did not change, for both the release branch and master. This is a lot of work for no benefit at all.

Those runtimes were NOT bumped on purpose, they were not forgotten :)

[bkontur]

@chevdor
so, there is no rule like "when spec_version is changed, we should also change Cargo.toml version" or something like that?

ok, no problem, I can close it

[NachoPal]

I am fine if you guys do not want to bump those spec_versions, it is not critical, but the runtimes do change. They depend on different substrate and polkadot versions, therefore they are different runtimes.

I see benefit at least for bumping the testing runtimes (penpal and rococo-parachain). It is not the same testing interactions with a v0.9.22 based testing parachain or a v0.9.27 one.