This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Support westend integration tests #2649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilescope
added
B0-silent
|
@NachoPal any problems with this? |
All good |
NachoPal
approved these changes
Jun 2, 2023
joepetrowski
approved these changes
Jun 2, 2023
parachains/integration-tests/emulated/assets/asset-hub-westend/src/tests/transact.rs
Show resolved
Hide resolved
| Westend::child_location_of(AssetHubWestend::para_id()).into(); | ||
|
|
||
| let weight_limit = WeightLimit::Unlimited; | ||
| let require_weight_at_most = Weight::from_parts(1000000000, 200000); |
There was a problem hiding this comment.
This can be a follow up project (maybe good for someone new), but we should have some core set of "user stories" that other chains would use transact for, and then set the weight values in these tests as actual * some_factor_of_safety, and if the tests fail in a new release because of weight, then we need to mark it as a breaking change. That way people can rely on these weights in tests to have some future proof-ness in their runtimes.
| #[test] | ||
| fn reserve_transfer_native_asset_from_relay_to_assets() { | ||
| // Init tests variables | ||
| let amount = POLKADOT_ED * 1000; |
There was a problem hiding this comment.
Suggested change
| let amount = POLKADOT_ED * 1000; | |
| let amount = WESTEND_ED * 1000; |
| #[test] | ||
| fn teleport_native_assets_from_relay_to_assets_para() { | ||
| // Init tests variables | ||
| let amount = POLKADOT_ED * 1000; |
There was a problem hiding this comment.
Suggested change
| let amount = POLKADOT_ED * 1000; | |
| let amount = WESTEND_ED * 1000; |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things appear in westend before kusama, (example asset-conversion pallet) so it's helpful if we can write integration tests targeting westend.
Also updates emulator to handle host version changes (westend is on v5 of the host interface)