Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

improve xcm-emulator macros #2985

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

improve xcm-emulator macros #2985

wants to merge 10 commits into from

Conversation

xlc
Copy link
Contributor

@xlc xlc commented Aug 9, 2023

Right now the code just not usable. I can tell the code is written in such a way that's not considered external usage, which defeats the purpose.

Changes:

  • Accept trailing comma
  • Improve hygiene
  • Delete unused/bad imports/exports

Kusama address: FoBryanE4CffsqaC7P3hC88N1cGx9fUBvJZXvikC8JxX3e1

@xlc xlc changed the title improve macros to accept trailing comma improve xcm-emulator macros Aug 9, 2023
@xlc
Copy link
Contributor Author

xlc commented Aug 14, 2023

I guess I wasted my time on this.

@xlc xlc closed this Aug 14, 2023
@xlc xlc reopened this Aug 16, 2023
@xlc
Copy link
Contributor Author

xlc commented Aug 16, 2023

Ok I am not going to continue to spend time to fix this. There are simply too many errors to fix and I don't have that much spare time.

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3394805

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants