-
Notifications
You must be signed in to change notification settings - Fork 380
feat(ci): update runtime build workflow #471
Conversation
Waiting for https://github.com/chevdor/cumulus/actions/runs/905829184 to pass |
- switch to a tag for the chevdor/srtool-actions - trigger to only tags & ignore folders not involved in the runtime - add weekly build schedule - add timestamp to the artifacts
6993093
to
9ca9b61
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just leaving a comment for now till my questions are addressed
on: | ||
push: | ||
tags: | ||
- "*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a specific pattern of tab we could match on rather than any tag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the existing tags (https://github.com/paritytech/cumulus/tags) and for now, the list is too short for a pattern. Since the frequency of new tags is still low, I think picking up all tags is better than every single push and fair for now. My proposal would be to refine the pattern as soon as we start using tags , that would trigger the runtime build but that we also want to exclude.
What is the point of this? |
Since the frequency of tagging is low (at least currently), I want to ensure we don't end up not building the runtime for a too long period of time and then discover potential issues with the CI when we do need it wot run and work. Why monday 2am: I think a weekly build is fair and not overdone. It runs when it will disturb no one and we will have potential issues visible mondays first hour. We totally can reconsider the frequency up or down if the activity of the repo changes one way or another. I think it can also be convenient for people who want to test to have a fairly fresh runtime build. |
And how will you find out that it doesn't build anymore? Remember to check every monday if the build succeeded? |
Okay, I didn't know that github actions support to send email automatically. That is fine. |
chevdor/srtool-actions
(previously using adraft
branch)