Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Enable permissionless asset creation #476

Merged
merged 6 commits into from
Jul 15, 2021
Merged

Enable permissionless asset creation #476

merged 6 commits into from
Jul 15, 2021

Conversation

gavofyork
Copy link
Member

No description provided.

@gavofyork gavofyork added the A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). label Jun 7, 2021
@apopiak @JoshOrndorff
Update polkadot-parachains/statemine-runtime/src/lib.rs
50470ae 
Co-authored-by: Joshy Orndorff <JoshOrndorff@users.noreply.github.com>
apopiak
apopiak approved these changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@apopiak apopiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xlc
Copy link
Contributor

xlc commented Jun 14, 2021

Does those needs an update given new parachains will be live soon?

cumulus/polkadot-parachains/statemine-runtime/src/lib.rs

Lines 591 to 594 in a84f786

type XcmExecuteFilter = All<(MultiLocation, Xcm<Call>)>;
type XcmExecutor = XcmExecutor<XcmConfig>;
type XcmTeleportFilter = All<(MultiLocation, Vec<MultiAsset>)>;
type XcmReserveTransferFilter = All<(MultiLocation, Vec<MultiAsset>)>;

@apopiak apopiak added the T7-system_parachains This PR/Issue is related to System Parachains. label Jun 24, 2021
joepetrowski
joepetrowski approved these changes Jul 12, 2021
View reviewed changes
Copy link
Contributor

@joepetrowski joepetrowski left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for release on Kusama provided cross-chain asset transfers are not enabled in the same upgrade in order to keep any Assets/Uniques issues local to Statemine.

apopiak
apopiak approved these changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@apopiak apopiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joepetrowski joepetrowski merged commit c905b56 into master Jul 15, 2021
@joepetrowski joepetrowski deleted the gav-unlease-assets branch July 15, 2021 14:51
@github-actions github-actions bot mentioned this pull request Aug 24, 2021
Closed
slumber pushed a commit that referenced this pull request Sep 1, 2021
@gavofyork @apopiak
@JoshOrndorff @joepetrowski @slumber
Enable permissionless asset creation (#476)
209ba67 
* Enable permissionless asset creation

* Fixes

* Fixes

* Update polkadot-parachains/statemine-runtime/src/lib.rs

Co-authored-by: Joshy Orndorff <JoshOrndorff@users.noreply.github.com>

* update Cargo.lock

Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>
Co-authored-by: Joshy Orndorff <JoshOrndorff@users.noreply.github.com>
Co-authored-by: joepetrowski <joe@parity.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshOrndorff JoshOrndorff JoshOrndorff left review comments

@joepetrowski joepetrowski joepetrowski approved these changes

@apopiak apopiak apopiak approved these changes

@shawntabrizi shawntabrizi shawntabrizi approved these changes

Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). T7-system_parachains This PR/Issue is related to System Parachains.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gavofyork @xlc @shawntabrizi @JoshOrndorff @apopiak @joepetrowski