This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Update weights from v4 for v5 comparison #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NachoPal
changed the title
apopiak
approved these changes
Oct 18, 2021
Comment on lines
-46
to
+72
| .saturating_add((3_745_000 as Weight).saturating_mul(a as Weight)) | ||
| .saturating_add(T::DbWeight::get().reads(4 as Weight)) | ||
| .saturating_add((27_058_000 as Weight).saturating_mul(s as Weight)) | ||
| // Standard Error: 378_000 | ||
| .saturating_add((33_069_000 as Weight).saturating_mul(a as Weight)) |
There was a problem hiding this comment.
Why did removing the approvals get so much more expensive? Ah, this is because it just updates the weights to v4 (which is missing in this branch because it wasn't upstreamed).
| // Storage: CollatorSelection LastAuthoredBlock (r:1000 w:1) | ||
| // Storage: System Account (r:1 w:1) | ||
| // Storage: CollatorSelection Invulnerables (r:1 w:0) | ||
| // Storage: System BlockWeight (r:1 w:1) |
There was a problem hiding this comment.
It's a bit odd that System BlockWeight is not whitelisted for the benchmarks, but not sure it's worth it to dive deep into this 🤷
apopiak
added a commit
that referenced
this pull request
Nov 8, 2021
* Update references * update deps * set substrate deps for pallet-asset-tx-payment * add DisabledValidatorsThreshold to parachain template * add DisabledValidatorsThreshold to statemint runtimes * adjust imports * update Cargo-lock * add DisabledValidatorsThreshold to mock config * cargo +nightly fmt * adjust on_disabled type * remove on_chain_votes function in ParachainHost impl * remove ScrapedOnChainVotes * bump polkadot-collator version Co-authored-by: Chevdor <chevdor@users.noreply.github.com> * update Cargo.lock * set spec_versions to 500 * Statemine cannot execute. * disallow XCM execute on statemint * cargo fmt * remove unnecessary dep on node-primitives * select parachains-common/std feature when building rococo-runtime with std * adjust Statemint to the three digit spec_version format * Add script to generate simple changelogs (#668) * Update weights from v4 for v5 comparison (#673) * updates weights * pallet_unique benchmarks added + weights upstream from v4 * Fix benchmarks after Parachain Template (#677) * updates weights * pallet_unique benchmarks added + weights upstream from v4 * benchmarks fix for parachain template * Weights updates for Statemine v5 (#682) * updates weights * pallet_unique benchmarks added + weights upstream from v4 * weights updates for statemine v5 * mention Storage in construct_runtime macro for pallet-xcm (#680) * Use pallet-xcm for version wrapping (#689) * use PolkadotXcm for XcmRouter WrapVersion * use PolkadotXcm for version wrapping Co-authored-by: Bryan Chen <xlchen1291@gmail.com> * patch weight for batch_all from rerun * Runtime version bump to v503 (#694) * adjust genesis value generation scripts to output entries array + add script to derive encoded call * add script to generate shell spec from runtime wasm * Ensure a bad datastream cannot cause problems (#701) * Ensure a bad datastream cannot cause problems * Formatting * Formatting * update Polkadot (to 0.9.11 169bab55d) * bump spec versions * Allow Queries and Subscriptions Fixes Formatting * fix build * make fmt happy * statemint imports * slight naming changes in script * add shell genesis data + wasm + chainspec * adjust generated shell spec with production config values * update Substrate and Polkadot to master * fix deps * swap out bootnodes for statemint shell * add a script for verifying the shell chain spec * add sha checksum for head data * remove verification script * remove hex wasm file * update Substrate and Polkadot again and fix compilation * update and fix lock file * formatting * remove redundant dispatch_as weight Co-authored-by: Bastian Köcher <info@kchr.de> Co-authored-by: Chevdor <chevdor@users.noreply.github.com> Co-authored-by: Gav Wood <gavin@parity.io> Co-authored-by: Ignacio Palacios <ignacio.palacios.santos@gmail.com> Co-authored-by: Bryan Chen <xlchen1291@gmail.com> Co-authored-by: joepetrowski <joe@parity.io>
chevdor
added a commit
that referenced
this pull request
Nov 11, 2021
* disable permissionless asset creation for Statemint (#669) * disable permissionless asset creation for Statemint * Companion for polkadot#3728 (#693) * Update mock runtime API * update Polkadot packages Co-authored-by: joao-paulo-parity <joao-paulo@parity.io> * Ensure a bad datastream cannot cause problems (#701) * Allow Queries and Subscriptions (#700) * Bump syn to 1.0.81 (#707) * Update Substrate & Polkadot (#709) * Udpate polkadot substrate (#713) * fmt with latest nightly * Bump subwasm version (#716) * Companion for `dispatch_as` (#715) * dispatch as companion * Upstream Statemine Release v5 Changes to Master (#720) * set substrate deps for pallet-asset-tx-payment * add DisabledValidatorsThreshold to parachain template * add DisabledValidatorsThreshold to mock config * adjust on_disabled type * remove on_chain_votes function in ParachainHost impl * remove ScrapedOnChainVotes * bump polkadot-collator version Co-authored-by: Chevdor <chevdor@users.noreply.github.com> * set spec_versions to 500 * Statemine cannot execute. * disallow XCM execute on statemint * remove unnecessary dep on node-primitives * select parachains-common/std feature when building rococo-runtime with std * adjust Statemint to the three digit spec_version format * Add script to generate simple changelogs (#668) * Update weights from v4 for v5 comparison (#673) * updates weights * pallet_unique benchmarks added + weights upstream from v4 * Fix benchmarks after Parachain Template (#677) * pallet_unique benchmarks added + weights upstream from v4 * benchmarks fix for parachain template * Weights updates for Statemine v5 (#682) * pallet_unique benchmarks added + weights upstream from v4 * weights updates for statemine v5 * mention Storage in construct_runtime macro for pallet-xcm (#680) * Use pallet-xcm for version wrapping (#689) * use PolkadotXcm for XcmRouter WrapVersion * use PolkadotXcm for version wrapping Co-authored-by: Bryan Chen <xlchen1291@gmail.com> * patch weight for batch_all from rerun * Runtime version bump to v503 (#694) * adjust genesis value generation scripts to output entries array + add script to derive encoded call * add script to generate shell spec from runtime wasm * Ensure a bad datastream cannot cause problems (#701) * Ensure a bad datastream cannot cause problems * update Polkadot (to 0.9.11 169bab55d) * bump spec versions * Allow Queries and Subscriptions * statemint imports * slight naming changes in script * add shell genesis data + wasm + chainspec * adjust generated shell spec with production config values * update Substrate and Polkadot to master * swap out bootnodes for statemint shell * add a script for verifying the shell chain spec * add sha checksum for head data * remove verification script * remove hex wasm file * update Substrate and Polkadot again and fix compilation * remove redundant dispatch_as weight Co-authored-by: Bastian Köcher <info@kchr.de> Co-authored-by: Chevdor <chevdor@users.noreply.github.com> Co-authored-by: Gav Wood <gavin@parity.io> Co-authored-by: Ignacio Palacios <ignacio.palacios.santos@gmail.com> Co-authored-by: Bryan Chen <xlchen1291@gmail.com> Co-authored-by: joepetrowski <joe@parity.io> * Rework the runtime upgrade test (#727) * Rework the runtime upgrade test * Update test/service/tests/runtime_upgrade.rs Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com> * Remove randomness collective flip new (#726) * randomess collective flip removed * remove migration for statemint Co-authored-by: Alexander Popiak <alexander.popiak@parity.io> * adjust XCM unit weights to 1B (#735) * Align Call Indices between Westmint and Statemint (#731) * align construct_runtime calls between statemint runtimes * bump westmint transaction_version * bump spec_version (#733) * point back to Polkadot 0.9.12 * adjust code to work with 0.9.12 again * adjust network test back to polkadot 0.9.12 * Align the Statemint Runtimes (#736) * align the different Statemint runtimes so they are more similar in structure * align Unpaid Execution filter * revert changes to Unpaid execution filter for Westmint * Bump spec versions (#742) Co-authored-by: Alexander Popiak <alexander.popiak@parity.io> Co-authored-by: Chris Sosnin <48099298+slumber@users.noreply.github.com> Co-authored-by: joao-paulo-parity <joao-paulo@parity.io> Co-authored-by: Gavin Wood <gavin@parity.io> Co-authored-by: Keith Yeung <kungfukeith11@gmail.com> Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com> Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com> Co-authored-by: Bastian Köcher <info@kchr.de> Co-authored-by: Ignacio Palacios <ignacio.palacios.santos@gmail.com> Co-authored-by: Bryan Chen <xlchen1291@gmail.com> Co-authored-by: joepetrowski <joe@parity.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge needed before #672 to be able to compare new weights for V5 with old ones in V4