Merge pull request #161 from davxy/master

Implement 'Eq' for 'Equivocation' struct
paritytech · Mar 8, 2023 · 6f2d42f · 6f2d42f
2 parents 218cdc6 + f28f890
commit 6f2d42f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/lib.rs b/src/lib.rs
@@ -208,7 +208,7 @@ pub trait Chain<H: Eq, N: Copy + BlockNumberOps> {
 }
 
 /// An equivocation (double-vote) in a given round.
-#[derive(Clone, Debug, PartialEq)]
+#[derive(Clone, Debug, PartialEq, Eq)]
 #[cfg_attr(feature = "derive-codec", derive(Encode, Decode, TypeInfo))]
 pub struct Equivocation<Id, V, S> {
 	/// The round number equivocated in.

diff --git a/src/vote_graph.rs b/src/vote_graph.rs
@@ -405,7 +405,7 @@ where
 			let mut new_best = None;
 			for d_node in &descendent_nodes {
 				if let Some(d_block) = d_node.ancestor_block(base_number + offset) {
-					match descendent_blocks.binary_search_by_key(&d_block, |&(ref x, _)| x) {
+					match descendent_blocks.binary_search_by_key(&d_block, |(x, _)| x) {
 						Ok(idx) => {
 							descendent_blocks[idx].1 += &d_node.cumulative_vote;
 							if condition(&descendent_blocks[idx].1) {