Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metadata V15 with Runtime API support #48

Merged
merged 19 commits into from
Mar 30, 2023
Merged

Add metadata V15 with Runtime API support #48

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
1e96d16
v15: Add everything from v14
lexnv Jan 20, 2023
54c60b0
v15: Add feature to make the V15 the default version
lexnv Jan 20, 2023
d7c949a
v15: Add trait metadata
lexnv Jan 20, 2023
0959e5c
v15: Add method metadata
lexnv Jan 20, 2023
c5aeb19
v15: Add param metadata
lexnv Jan 20, 2023
78c2963
v15: Constructor for the metadata
lexnv Jan 20, 2023
51d40ef
v14: Keep backwards compatibility with v14 re-exports
lexnv Jan 20, 2023
94831c4
v15: Add trait and method documentation
lexnv Jan 20, 2023
cd88281
v15: Make trait version optional
lexnv Jan 20, 2023
c5e8d98
v15: Do not reexport v14 types
lexnv Jan 23, 2023
c948b95
v15: Expose metadata as unstable
lexnv Jan 30, 2023
b62988f
v15: Exclude trait versioning from metadata
lexnv Jan 31, 2023
90b4e6d
v15: Add pallet documentation
lexnv Mar 15, 2023
3e574f3
v15: Rename runtime API structs
lexnv Mar 15, 2023
3f17693
v15: Rename `ParamMetadata` to RuntimeApiMethodParamMetadata
lexnv Mar 15, 2023
b20c509
Update frame-metadata/src/v15.rs
lexnv Mar 29, 2023
69e1eb5
v15: Reanme `runtime` -> `apis` and use global META_RESERVED
lexnv Mar 29, 2023
2ae624a
lib: Force CI by better docs
lexnv Mar 29, 2023
7549413
Copyright: Align copyright with substrate
lexnv Mar 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions frame-metadata/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ v12 = []
v13 = []
legacy = ["v13", "v12", "v11", "v10", "v9", "v8"]
v14 = ["scale-info"]
v15-unstable = ["scale-info"]

# Serde support without relying on std features
serde_full = [
Expand Down
11 changes: 11 additions & 0 deletions frame-metadata/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,10 @@ pub mod v13;
#[cfg(feature = "v14")]
pub mod v14;

/// Metadata v15
#[cfg(feature = "v15-unstable")]
pub mod v15;

// Reexport all the types from the latest version.
//
// When a new version becomes available, update this.
Expand Down Expand Up @@ -172,6 +176,12 @@ pub enum RuntimeMetadata {
/// Version 14 for runtime metadata, as raw encoded bytes.
#[cfg(not(feature = "v14"))]
V14(OpaqueMetadata),
/// Version 15 for runtime metadata.
#[cfg(feature = "v15-unstable")]
V15(v15::RuntimeMetadataV15),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't notice, but how do you ask for V15 metadata in Substrate; will you ask for metadata_at_version(u32::MAX) or something? Or do you ask for 15? Just wondeirng whether we do anything to highlight the instability of it in the code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, in substrate we'll have to ask for u32::MAX until we can call the v15 stable

/// Version 15 for runtime metadata, as raw encoded bytes.
#[cfg(not(feature = "v15-unstable"))]
V15(OpaqueMetadata),
}

impl RuntimeMetadata {
Expand All @@ -193,6 +203,7 @@ impl RuntimeMetadata {
RuntimeMetadata::V12(_) => 12,
RuntimeMetadata::V13(_) => 13,
RuntimeMetadata::V14(_) => 14,
RuntimeMetadata::V15(_) => 15,
}
}
}
Expand Down
Loading