Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

archive/storage: Use a similar API with chainHead #90

Closed
wants to merge 4 commits into from

Conversation

lexnv
Copy link
Contributor

@lexnv lexnv commented Sep 11, 2023

The following changes are done to the archive methods:

  • Use integers for describing block heights instead of strings containing integers
  • Provide a similar API for archive_storage as for the chainHead_storage
  • Use camel case for event description

cc @tomaka @jsdw @josepot @paritytech/subxt-team

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@tomaka
Copy link
Contributor

tomaka commented Sep 12, 2023

This should IMO be multiple different PRs. I don't see why they're bundled in one.

@lexnv lexnv closed this Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants