Additional improvements to integrate pubsub with Parity #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
reviewed
Apr 12, 2017
macros/src/pubsub.rs
Outdated
|
|
||
| fn start_send(&mut self, item: Self::SinkItem) -> futures::StartSend<Self::SinkItem, Self::SinkError> { | ||
| if self.poll()?.is_not_ready() { | ||
| return Ok(futures::AsyncSink::NotReady(item)); |
There was a problem hiding this comment.
does this need to schedule a Task wakeup?
There was a problem hiding this comment.
I'm pretty sure it doesn't, but putting the rationale why in a comment above (since futures have a lot of hidden complexity) would help
|
I am not familiar with how |
|
Nightly failure seems unrelated to the changes. See rust-lang/rustup#1062 for more details. |
tomusdrw
added a commit
that referenced
this pull request
Apr 13, 2017
* Cloneable types * Adding Origin to RequestContext * Sink implementations. * Add comment regarding Task wakeup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #109