Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

One way serialize for subscriber type #371

Merged
merged 4 commits into from
Jan 30, 2019
Merged

One way serialize for subscriber type #371

merged 4 commits into from
Jan 30, 2019

Conversation

ascjones
Copy link
Contributor

Fixes #370

ascjones
ascjones commented Jan 30, 2019
View reviewed changes
derive/tests/run-pass/pubsub-subscription-type-without-deserialize.rs
extern crate jsonrpc_pubsub;
#[macro_use]
extern crate jsonrpc_derive;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to get --edition=2018 working with compiletests, but couldn't manage

@ascjones ascjones requested a review from tomusdrw January 30, 2019 12:51
@tomusdrw tomusdrw merged commit 2fe3bfc into master Jan 30, 2019
@tomusdrw tomusdrw deleted the aj-one-way-serialize-for-subscriber-type branch January 30, 2019 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomusdrw tomusdrw tomusdrw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ascjones @tomusdrw