Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jsonrpc-derive details. #372

Merged
merged 3 commits into from
Jan 31, 2019
Merged

Add jsonrpc-derive details. #372

merged 3 commits into from
Jan 31, 2019

Conversation

tomusdrw
Copy link
Contributor

No description provided.

@tomusdrw tomusdrw requested a review from ascjones January 31, 2019 12:24
@@ -3,6 +3,10 @@ name = "jsonrpc-derive"
version = "10.0.0"
authors = ["Parity Technologies <admin@parity.io>"]
edition = "2018"
license = "MIT"
documentation = "https://paritytech.github.io/jsonrpc/jsonrpc_derive/index.html"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not using docs.rs here? :D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, this one displays docs from master, but in the toml descriptions we should use docs.rs

Copy link
Contributor

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

@tomusdrw tomusdrw merged commit 8ffc7f3 into master Jan 31, 2019
@tomusdrw tomusdrw deleted the td-details branch January 31, 2019 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants