-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strict parsing for core
#448
Conversation
core
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like strict
more... jsonrpc provides a way to send arbitrary data in a params
field, so I don't see a reason why someone would need to use other fields
@debris Yeah, I'm more inclined to go with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Agree about strict
core
core
I opened a follow up issue here: |
Some types in
Response
were missingdeny_unknown_fields
that would cause invalid response to be parsed correctly whenDeserializing
.However later I started thinking if having a less strict version would be useful as well, hence I introduced the
strict
feature.I'd like to hear your opinions on whether we want to maintain
strict
andnon-strict
versions or rather default tostrict
.See: tomusdrw/rust-web3#222 (comment) why non strict mode would be useful.