move to rust 2021, macro tweak to compile #650
Conversation
nuke-web3
changed the title
| @@ -78,7 +78,7 @@ pub fn generate_client_module( | |||
| #(#client_methods)* | |||
| } | |||
|
|
|||
| impl#generics From<RpcChannel> for Client#generics | |||
| impl #generics From<RpcChannel> for Client #generics | |||
There was a problem hiding this comment.
What would happen if you did not make these whitespace changes?
There was a problem hiding this comment.
That is done by cargo fix.
See: https://doc.rust-lang.org/edition-guide/rust-2021/reserving-syntax.html
rust-version = "1.56.1" style for [package] field
|
For reference, I tried to get this to With |
nuke-web3
requested review from
KiChjang and
bkchr
and removed request for
KiChjang
| @@ -1,14 +1,15 @@ | |||
| [package] | |||
| name = "jsonrpc-client-transports" | |||
| version = "18.0.0" | |||
There was a problem hiding this comment.
We should probably bump the major versions everywhere due to different compiler requirements.
There was a problem hiding this comment.
do you mean minor or patch? 18.1.0 makes sense to me, as its compatible with 18.0.0
maybe even just 18.0.1 as this doesn't effect the behavior of the program
There was a problem hiding this comment.
I actually really meant major. The thing is that we now suddenly require everyone to use a specific Rust compiler version which IMHO is a breaking change. But I'm not a semver expert, maybe @dvdplm has some suggestions.
There was a problem hiding this comment.
MSRV changes are generally considered breaking. v19! :)
There was a problem hiding this comment.
Oh well, I can do that here, sure! But I know that many do not do this (I put in a lot of PRs across parity for this, and it so far has not been)
Happy to update across the board and reference this thread to justify.
Do note that it's not universally agreed that MSVR bump = breaking change.
Confirmed to build and pass tests locally on Ubuntu 20.04.3 LTS: