Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nonstrict feature to jsonrpc-core #677

Closed
wants to merge 4 commits into from
Closed

add nonstrict feature to jsonrpc-core #677

wants to merge 4 commits into from

Conversation

clouds56
Copy link

With nonstrict, we do not deny any unknown field, instead we collect them into other field.
This maybe fixes #595

@clouds56
Copy link
Author

clouds56 commented Aug 2, 2022

I'd like to check failed tests, but I do not have access to the gitlab.

Your account is pending approval from your GitLab administrator and hence blocked.
Please contact your GitLab administrator if you think this is an error.

@niklasad1
Copy link
Member

Hey, it's just cargo fmt that fails so run it on your code and it should make the CI happy

@perekopskiy
Copy link

Hi, if this PR is going to lend eventually, I'd like to ask you to remove #[serde(deny_unknown_fields)] with non-strict mode not only for the responses but for the requests too. The reason is some clients include non-standard fields and some servers need to maintain it.

@niklasad1
Copy link
Member

niklasad1 commented Dec 9, 2022

hey again,

we are not maintaining this library actively anymore, https://github.com/paritytech/jsonrpsee already supports this

@clouds56 clouds56 closed this by deleting the head repository May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to drop deny_unknown_fields annotations
3 participants