Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[types]: jsonrpc_v2 types write serialize/deserialize tests. #276

Closed
niklasad1 opened this issue Apr 20, 2021 · 0 comments · Fixed by #389
Closed

[types]: jsonrpc_v2 types write serialize/deserialize tests. #276

niklasad1 opened this issue Apr 20, 2021 · 0 comments · Fixed by #389

Comments

@niklasad1
Copy link
Member

niklasad1 commented Apr 20, 2021 •
edited
Loading

We should have some fine-grained tests for the types to comply with the spec.

For example using serde_json::RawValue as JSON-RPC Params would not ensure that it is an valid JSON-RPC param...

Ideally we would unify the types and don't have to test so many different types. For example is many cases we have one type for serializing and one for deserialization, see JsonRpcParams and RpcParams.
This was referenced Apr 20, 2021
Merged
Closed
@niklasad1 niklasad1 changed the title [types]: write serialize/deserialize tests. [types]: jsonrpc_v2 types write serialize/deserialize tests. Apr 22, 2021
@niklasad1 niklasad1 mentioned this issue Apr 30, 2021
Merged
@dvdplm dvdplm mentioned this issue Jun 15, 2021
Closed
13 tasks
@niklasad1 niklasad1 mentioned this issue Jun 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[jsonrpsee types]: unify a couple of types + more tests paritytech/jsonrpsee
1 participant
@niklasad1