[jsonrpsee types]: unify a couple of types + more tests #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TarikGul
reviewed
Jun 22, 2021
TarikGul
reviewed
Jun 22, 2021
TarikGul
reviewed
Jun 22, 2021
| }) | ||
| .expect("valid json infallible; qed"); | ||
| let msg = | ||
| self.build_message(&SubscriptionClosedError::from(close_reason)).expect("valid json infallible; qed"); |
There was a problem hiding this comment.
https://en.wikipedia.org/wiki/Q.E.D.
basically, a hand-wavy proof that a given unwrap/expect is infallible otherwise it would crash the thread that executed the code.
There was a problem hiding this comment.
It's latin, old-europe snobbish way of saying "tada!"
TarikGul
approved these changes
Jun 22, 2021
dvdplm
added a commit
that referenced
this pull request
Jul 6, 2021
* master: (21 commits) New proc macro (#387) Streaming RpcParams parsing (#401) Set allowed Host header values (#399) Synchronization-less async connections in ws-server (#388) [ws server]: terminate already established connection(s) when the server is stopped (#396) feat: customizable JSON-RPC error codes via new enum variant on `CallErrror` (#394) [ci]: test each individual crate's manifest (#392) Add a way to stop servers (#386) [jsonrpsee types]: unify a couple of types + more tests (#389) Update roadmap link in readme (#390) Cross-origin protection (#375) Method aliases + RpcModule: Clone (#383) Use criterion's async bencher (#385) Async/subscription benches (#372) send text (#374) Fix link to ws server in README.md (#373) Concat -> simple push (#370) Add missing `rt` feature (#369) Release prep for v0.2 (#368) chore(scripts): publish script (#354) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some additional tests to close #276 (remaining is the ignored tests for
RpcParamsthat are untyped but as long we provideRpcParams::parsefor it, it should be fine)Then I was annoyed of writing so much tests so I unified
JsonRpcNotifResponse and JsonRpcNotificationandJsonRpcNotificationParamsAlloc andJsonRpcNotificationParams`.Thus, I replaced
RawValuewithTit will require allocations when deserializing but the benefit is that we don't have convert values toRawValuewhen sending stuff via theSubscriptionSink