-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calling deprecated methods – warn? #564
Comments
8 tasks
That's good idea I like it |
lexnv
added a commit
to lexnv/jsonrpsee
that referenced
this issue
Nov 21, 2021
Calling a deprecated method of the RPC client should warn the user at compile-time. Extract the `#[deprecated]` macro as is while parsing the RpcMethod, and pass through the macro to the RPC client rendering.
lexnv
added a commit
to lexnv/jsonrpsee
that referenced
this issue
Nov 21, 2021
To ensure that the test will fail during compilation, warnings are denied. Check that the deprecate macro will generate warnings just for the methods that are utilized.
PR for deprecated methods: #570 |
niklasad1
pushed a commit
that referenced
this issue
Nov 21, 2021
* proc-macros: Fix documentation typo of `rpc_identifier` * proc-macros: Support deprecated methods for rpc client (#564) Calling a deprecated method of the RPC client should warn the user at compile-time. Extract the `#[deprecated]` macro as is while parsing the RpcMethod, and pass through the macro to the RPC client rendering. * tests/ui: Check deprecated method for rpc client (#564) To ensure that the test will fail during compilation, warnings are denied. Check that the deprecate macro will generate warnings just for the methods that are utilized.
Closed by #570 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Consider an RPC server where some methods are marked as deprecated:
Ideally, using the generated Rust client should inform/warn the user when
client.sync_method()
is called. Preferably at compile time.e.g. paritytech/substrate#8783 (comment)
The text was updated successfully, but these errors were encountered: