Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix server: don't send error on JSON-RPC notifications #1021

Merged
merged 5 commits into from
Feb 16, 2023

Conversation

niklasad1
Copy link
Member

@niklasad1 niklasad1 commented Feb 16, 2023

After some refactoring I introduced a bug where the notifications were not handled properly and were treated as JSON-RPC errors.

Also in the batch responses Notification<T> was used such that missing params<T> became a serde decoding error when it was missing and needs to be handled as Option<serde_json::RawValue> instead.

Close #1017

@niklasad1 niklasad1 requested a review from a team as a code owner February 16, 2023 09:31
server/src/transport/ws.rs Outdated Show resolved Hide resolved
@niklasad1 niklasad1 changed the title fix server: don't send error JSON-RPC notifications fix server: don't send error on JSON-RPC notifications Feb 16, 2023
@niklasad1 niklasad1 merged commit 3227aea into master Feb 16, 2023
@niklasad1 niklasad1 deleted the na-fix-notification-handling branch February 16, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON RPC notification
3 participants