fix server: don't send error on JSON-RPC notifications #1021
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some refactoring I introduced a bug where the notifications were not handled properly and were treated as JSON-RPC errors.
Also in the batch responses
Notification<T>
was used such thatmissing params<T>
became a serde decoding error when it was missing and needs to be handled asOption<serde_json::RawValue>
instead.Close #1017