Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc module: remove SubscriptionAnswer #1025

Merged
merged 5 commits into from
Feb 22, 2023

Conversation

niklasad1
Copy link
Member

This abstraction is not very nice and I think it's more readable with Result<MethodResult, Id> anyway so let's remove it.

This abstraction is not very nice and I think it's more readable with Result<MethodResult, Id>
anyway so let's remove it.
@niklasad1 niklasad1 requested a review from a team as a code owner February 17, 2023 17:10
server/src/transport/ws.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one less type :)

@niklasad1 niklasad1 merged commit afe40df into master Feb 22, 2023
@niklasad1 niklasad1 deleted the na-rpc-kill-subscription-answered branch February 22, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants