-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: introduce workspace attributes and add keywords #1077
docs: introduce workspace attributes and add keywords #1077
Conversation
documentation = "https://docs.rs/jsonrpsee" | ||
homepage = "https://www.parity.io/" | ||
keywords = ["jsonrpc", "json", "http", "websocket", "WASM"] | ||
readme = "README.md" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any idea how it resolves this in dependencies; does it use the path relative to this workspace toml?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to https://doc.rust-lang.org/cargo/reference/workspaces.html#the-package-table it should work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah; readme and license paths are relative to the workspace root, ok cool! Not so useful if you want to have crate specific readme's but good if you just want to use the same one for all crates, so makes sense to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; I guess you didn't want to inherit authors for all because those other crates were post-Pierre?
Not sure how README path inherits; maybe it just works; would be good to know :)
I was just lazy with the test crates, I'll fix it tomorrow. |
…add-keywords' into na-introduce-workspace-attr-and-add-keywords
According to https://doc.rust-lang.org/cargo/reference/workspaces.html#the-package-table it should work |
…ace-attr-and-add-keywords
Close #970