Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(proc macros): support parsing params !Result #1094

Merged
merged 2 commits into from
Apr 24, 2023
Merged

fix(proc macros): support parsing params !Result #1094

merged 2 commits into from
Apr 24, 2023

Conversation

niklasad1
Copy link
Member

@niklasad1 niklasad1 commented Apr 24, 2023 •
edited
Loading

Fixes #1093

@niklasad1 niklasad1 requested a review from a team as a code owner April 24, 2023 10:05
@niklasad1 niklasad1 changed the title fi(proc macros): support parsing param !Result fi(proc macros): support parsing params !Result Apr 24, 2023
@niklasad1 niklasad1 changed the title fi(proc macros): support parsing params !Result fix(proc macros): support parsing params !Result Apr 24, 2023
tadeohepperle
tadeohepperle approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@tadeohepperle tadeohepperle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@niklasad1 niklasad1 merged commit e58e021 into master Apr 24, 2023
@niklasad1 niklasad1 deleted the na-fix-1093 branch April 24, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadeohepperle tadeohepperle tadeohepperle approved these changes

@lexnv lexnv lexnv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

proc macros: IntoResponse doesn't work for parameters that isn't Result
3 participants
@niklasad1 @lexnv @tadeohepperle