Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add as_str getter for Params #1173

Merged
merged 1 commit into from
Aug 8, 2023
Merged

feat: add as_str getter for Params #1173

merged 1 commit into from
Aug 8, 2023

Conversation

polachok
Copy link
Contributor

@polachok polachok commented Aug 8, 2023

This is useful for logging params in an implementation of Logger.

@polachok polachok requested a review from a team as a code owner August 8, 2023 07:52
jsdw
jsdw approved these changes Aug 8, 2023
View reviewed changes
Copy link
Collaborator

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fair :)

@niklasad1 niklasad1 changed the title feat: get params as str feat: add as_str getter for Params Aug 8, 2023
@niklasad1 niklasad1 merged commit 76fddae into paritytech:master Aug 8, 2023
@polachok polachok deleted the params-string branch August 22, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklasad1 niklasad1 niklasad1 approved these changes

@jsdw jsdw jsdw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@polachok @jsdw @niklasad1