refactor(server): move host filtering to tower middleware #1179
Conversation
| pub use host_filter::*; | ||
| pub use proxy_get_request::*; |
There was a problem hiding this comment.
Nit: Given that host_filter has types like Authority etc in, maybe it's best to expose each one in its own module so it's obvious which types are for what (especially if we ever add any more)?
There was a problem hiding this comment.
Added an uri mod and simplified the host_filter mod, lemme know if you are happy with it? :)
There was a problem hiding this comment.
Def looks better now that the name Host is in all of the exposed things! Personally I liked that the Authority stuff lived here (because it's only used in this filter so keeping the code next to it felt good) but I'm easy either way :)
server/src/transport/http.rs
Outdated
| pub(crate) fn fetch_authority(request: &hyper::Request<hyper::Body>) -> Option<&str> { | ||
| let host_header = http_helpers::read_header_value(request.headers(), hyper::header::HOST); | ||
| let uri = request.uri().authority(); | ||
| pub(crate) fn authority(request: &hyper::Request<hyper::Body>) -> Option<Authority> { |
There was a problem hiding this comment.
Is this only used in the middleware now; I wonder whether it should move there?
There was a problem hiding this comment.
I moved it to Authority::from_http_request I think that's cleaner
…eware' into na-host-filtering-as-tower-middleware
This PR moves the
HTTP host filtercode to tower middleware and it's optional to use.It breaks the functionality somewhat as the old code checked that
hostwas included in the request even when host filtering were disabled and now jsonrpsee doesn't check anything in the host header or URI when host filtering is not enabled.It breaks the current API and the host filtering can only be enabled as middleware in this PR.
Close #868