[proc macros]: support generic type params #436
Conversation
niklasad1
changed the title
| fn subscribe_storage(&self, mut sink: SubscriptionSink, keys: Option<Vec<u8>>) { | ||
| sink.send(&keys.unwrap_or_default()).unwrap(); | ||
| fn subscribe_storage(&self, mut sink: SubscriptionSink, _keys: Option<Vec<ExampleStorageKey>>) { | ||
| sink.send(&vec![[0; 32]]).unwrap(); |
There was a problem hiding this comment.
Maybe produce a few more items here?
proc-macros/src/helpers.rs
Outdated
| fn visit_return_type(&mut self, return_type: &'ast syn::ReturnType) { | ||
| self.visiting_return_type = true; | ||
| visit::visit_return_type(self, return_type); | ||
| self.visiting_return_type = false | ||
| } |
There was a problem hiding this comment.
Same question here, I have a hard time understanding what visit::visit_return_type does and why we need the true/false stuff. Some docs would be good.
There was a problem hiding this comment.
I have "borrowed" this code from jsonrpc and I think it's to make it possible to know whether it's a return type or param when visiting the Ident in fn visit_ident
proc-macros/src/new/render_server.rs
Outdated
|
|
||
| let where_clause = server_generate_where_clause(&self.trait_def); | ||
|
|
||
| // NOTE(niklasad1): empty where clause is valid rust syntax. |
There was a problem hiding this comment.
TIL too! (I do like how Rust syntax is generally very amenable to code gen)
niklasad1
changed the title
Co-authored-by: David <dvdplm@gmail.com>
Co-authored-by: David <dvdplm@gmail.com>
| fn subscribe_storage(&self, mut sink: SubscriptionSink, keys: Option<Vec<u8>>) { | ||
| sink.send(&keys.unwrap_or_default()).unwrap(); | ||
| fn subscribe_storage(&self, mut sink: SubscriptionSink, _keys: Option<Vec<ExampleStorageKey>>) { | ||
| sink.send(&vec![[0; 32]]).unwrap(); |
There was a problem hiding this comment.
technically, we don't have any compile time check that actually only Vec<Hash> can sent over the sink because send has T: Serialize bound.... not sure if we want ensure that at compile-time
niklasad1
changed the title
| let mut sub = client.subscribe_storage(None).await.unwrap(); | ||
| assert_eq!(Some(vec![]), sub.next().await.unwrap()); | ||
| let mut sub: Subscription<Vec<ExampleHash>> = | ||
| RpcClient::<ExampleHash, ExampleStorageKey>::subscribe_storage(&client, None).await.unwrap(); |
There was a problem hiding this comment.
annoying to have to add these type hints but I think the issue for that is that we implement the client trait for T and these are not known in this cause at least not ExampleStorageKey ^^
|
@dvdplm @jsdw @maciejhirsz can you have another look at this? I think it should ready. |
Co-authored-by: David <dvdplm@gmail.com>
Co-authored-by: David <dvdplm@gmail.com>
Co-authored-by: David <dvdplm@gmail.com>
Co-authored-by: David <dvdplm@gmail.com>
…psee into na-proc-macros-generics
So this the first step for support generic params on the
traitin theproc macrosFor now I have ignored the
JSON Mapsupport as it currently not is used that widely used at least by us (substrate etc) and looks quite annoying to fix theserde implsIn addition I added that our
proc macrosadds the required traits bounds under the hood, it's quite annoying the repeat those everywhere as user of the API. I think this should be it...Substrate companion: paritytech/substrate@dp-jsonrpsee-integration-2...na-jsonrpsee-proc-macros
Nice to have: