Add testing facilities for subscriptions #459
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log more when params parsing fails
niklasad1
reviewed
Sep 10, 2021
niklasad1
reviewed
Sep 10, 2021
niklasad1
reviewed
Sep 10, 2021
niklasad1
reviewed
Sep 13, 2021
niklasad1
reviewed
Sep 13, 2021
niklasad1
reviewed
Sep 13, 2021
niklasad1
reviewed
Sep 13, 2021
niklasad1
approved these changes
Sep 13, 2021
niklasad1
reviewed
Sep 13, 2021
Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com>
…rpsee into dp-debug-substrate-tests
dvdplm
commented
Sep 13, 2021
utils/Cargo.toml
Outdated
Comment on lines
43
to
46
| # jsonrpsee-proc-macros = { path = "../proc-macros" } | ||
| # jsonrpsee-types = { path = "../types" } | ||
| # jsonrpsee-ws-server = { path = "../ws-server" } |
There was a problem hiding this comment.
@niklasad1 Is this a known gotcha with the proc macro? I couldn't make the proc macro work without importing the full jsonrpsee crate.
There was a problem hiding this comment.
ah right, I see that's expected.
Can't you move this test to integration-tests/proc macros instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing subscriptions
Log more information to help test authors to debug params parsing issues.
Add a way to interact with subscriptions without spinning up a server.