Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tracing-subscriber requirement from 0.2 to 0.3 #540

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 25, 2021

Updates the requirements on tracing-subscriber to permit the latest version.

Release notes

Sourced from tracing-subscriber's releases.

tracing-subscriber v0.3.0

0.3.0 (Oct 22, 2021)

This is a breaking release of tracing-subscriber. The primary breaking change in this release is the removal of the dependency on the [chrono crate], due to [RUSTSEC-2020-0159]. To replace chrono, support is added for formatting timestamps using the [time crate] instead.

In addition, this release includes a number of other breaking API changes, such as adding (limited) support for #![no_std] targets, removing previously deprecated APIs, and more.

Breaking Changes

  • Removed APIs deprecated in the v0.2.x release series.

  • Renamed Layer::new_span to Layer::on_new_span (#1674)

  • Removed Layer impl for Arc<L: Layer<S>> and Arc<dyn Layer<S> + ...> (#1649)

  • Replaced the [chrono crate] with the [time crate] for timestamp formatting, to resolve [RUSTSEC-2020-0159] (#1646)

  • Removed json and env-filter from default features. They must now be enabled explicitly (#1647)

  • Changed FormatEvent::format_event and FormatFields::format_fields trait methods to take a Writer type, rather than a &mut dyn fmt::Write trait object (#1661)

  • Changed the signature of the MakeWriter trait by adding a lifetime parameter (#781)

    Changed

  • layer: Renamed Layer::new_span to Layer::on_new_span (#1674)

  • fmt: Changed FormatEvent::format_event and FormatFields::format_fields trait methods to take a Writer type, rather than a &mut dyn fmt::Write trait object (#1661)

  • json, env-filter: json and env-filter feature flags are no longer enabled by default (#1647)

    Removed

  • Removed deprecated CurrentSpan type (#1320)

  • registry: Removed deprecated SpanRef::parents iterator, replaced by SpanRef::scope in #1431 ([#1648)])

  • layer: Removed deprecated Context::scope iterator, replaced by Context::span_scope and Context::event_scope in #1431 and #1434 (#1648)

  • layer: Removed Layer impl for Arc<L: Layer<S>> and Arc<dyn Layer<S> + ...>. These interfere with per-layer filtering. (#1649)

  • fmt: Removed deprecated LayerBuilder type (#1673)

  • fmt: Removed fmt::Layer::on_event (renamed to fmt::Layer::fmt_event) (#1673)

... (truncated)

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Oct 25, 2021
niklasad1
niklasad1 previously approved these changes Oct 25, 2021
@dvdplm
Copy link
Contributor

dvdplm commented Oct 25, 2021

I suspect substrate might break with this upgrade, perhaps we should hold off until we know it works there?

@niklasad1
Copy link
Member

niklasad1 commented Oct 25, 2021

I suspect substrate might break with this upgrade, perhaps we should hold off until we know it works there?

Sure, let's do that

@niklasad1 niklasad1 dismissed their stale review October 25, 2021 13:04

wait until we got in substrate

@dependabot dependabot bot force-pushed the dependabot/cargo/tracing-subscriber-0.3 branch from 9a054be to 621f412 Compare November 9, 2021 14:58
@dependabot dependabot bot force-pushed the dependabot/cargo/tracing-subscriber-0.3 branch from 621f412 to eef94c4 Compare December 1, 2021 09:22
@dependabot dependabot bot requested a review from a team as a code owner December 1, 2021 09:22
@dependabot dependabot bot force-pushed the dependabot/cargo/tracing-subscriber-0.3 branch from eef94c4 to eedf1ca Compare December 1, 2021 11:01
@dependabot dependabot bot force-pushed the dependabot/cargo/tracing-subscriber-0.3 branch 2 times, most recently from a6943c3 to 85153d7 Compare December 9, 2021 15:22
Updates the requirements on [tracing-subscriber](https://github.com/tokio-rs/tracing) to permit the latest version.
- [Release notes](https://github.com/tokio-rs/tracing/releases)
- [Commits](tokio-rs/tracing@tracing-subscriber-0.2.0...tracing-subscriber-0.3.0)

---
updated-dependencies:
- dependency-name: tracing-subscriber
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/cargo/tracing-subscriber-0.3 branch from 85153d7 to edb02e3 Compare December 20, 2021 17:10
@niklasad1
Copy link
Member

niklasad1 commented Dec 20, 2021

I think that we should merge this it's the tracing subscriber is only used by the examples and tests so should safe.

@dvdplm
Copy link
Contributor

dvdplm commented Dec 20, 2021

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 20, 2021

Looks like this PR is already up-to-date with master! If you'd still like to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@dvdplm
Copy link
Contributor

dvdplm commented Dec 21, 2021

Closing in favor of #615

@dvdplm dvdplm closed this Dec 21, 2021
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 21, 2021

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/cargo/tracing-subscriber-0.3 branch December 21, 2021 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants