Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: WASM client via web-sys transport #648
feat: WASM client via web-sys transport #648
Changes from 15 commits
261adb9
6e8324d
6831194
d671947
908a156
b6e1e04
0497648
267d260
e03566b
8307117
d2769e0
6346a8b
f7351f4
7d8a688
1414280
8e6028e
e56c099
12b383b
337d76d
520edfc
f006173
9baac7f
d98659b
56fccd2
ff3e0b6
40a3bdd
f2389ab
3ac6dbb
af3884e
4ec7477
34e1dbb
0b8ff78
6b32049
b558166
1fc3705
0972961
c683541
ee4bb2f
cad8c75
7d6e9e5
b2de6d0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rustwasm/wasm-bindgen#955
The
JsValue
is !Send and I had to use another channel here instead of havingWebSocket
here directly.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah maybe this answers my question about not impling Send on the wasm Transport traits!