Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client): close subscription when server sent SubscriptionClosed notification #721

Merged
merged 2 commits into from
Apr 1, 2022
Merged

fix(client): close subscription when server sent SubscriptionClosed notification #721

merged 2 commits into from
Apr 1, 2022

Conversation

niklasad1
Copy link
Member

@niklasad1 niklasad1 requested a review from a team as a code owner April 1, 2022 13:41
jsdw
jsdw approved these changes Apr 1, 2022
View reviewed changes
Copy link
Collaborator

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jsdw jsdw requested a review from a team April 1, 2022 15:16
@niklasad1 niklasad1 merged commit f55ab3e into master Apr 1, 2022
@niklasad1 niklasad1 deleted the na-client-close-down-subscription-on-custom-close-notif branch April 1, 2022 16:53
@niklasad1 niklasad1 mentioned this pull request Apr 4, 2022
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TarikGul TarikGul TarikGul approved these changes

@jsdw jsdw jsdw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@niklasad1 @jsdw @TarikGul