server: Optimize sending for SubscriptionSink::pipe_from_stream
#901
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SubscriptionSink::send
contains the logic for:While this offers ergonomic benefits for the server users not needing
to handle the accepting of the subscription, this function is exercised
during
SubscriptionSink::pipe_from_stream
.The
SubscriptionSink::pipe_from_stream
first accepts the subscriptionif previously not accepted, then it submits to the client side each element
from the provided stream. The sending of elements can be optimized
to not accept the subscription because it was priorly accepted.
This PR creates an inner private helper function for sending the response
to the client without accepting the subscription.