fix(server): log connections properly #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes that the connection count is read after a connection has been accepted and not before which cause this log to be out of order.
jsdw
approved these changes
Nov 7, 2022
lexnv
approved these changes
Nov 7, 2022
There was a problem hiding this comment.
The test seems to fail because of the change in compile UI tests
note: required for `<Conf as Config>::Hash` to implement `DeserializeOwned`
to
note: required because of the requirements on the impl of `DeserializeOwned` for `<Conf as Config>::Hash`
I think we could just restart the test with TRYBUILD=overwrite
That's just because the gitlab CI is using an old rustc version, I updated it to work with the latest rustc version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes that the connection count is read before the connection has attempted to converted in a HTTP connection which may cause the log is updated when that occurs.
In addition I refactored the connection task to separate function such that all occurs in the same connection tracing span.