Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): wasm tests #946

Merged
merged 5 commits into from
Nov 21, 2022
Merged

fix(ci): wasm tests #946

merged 5 commits into from
Nov 21, 2022

Conversation

niklasad1
Copy link
Member

@niklasad1 niklasad1 commented Nov 21, 2022

This PR installs chrome and firefox explicitly to ensure that wasm-pack finds the chrome and firefox drivers.

@niklasad1 niklasad1 changed the title debug wasm CI fix(ci): wasm tests Nov 21, 2022
@niklasad1 niklasad1 marked this pull request as ready for review November 21, 2022 14:32
@niklasad1 niklasad1 requested review from a team as code owners November 21, 2022 14:32
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@lexnv lexnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The wasm test is passing now 👍

@niklasad1 niklasad1 merged commit 7893ea0 into master Nov 21, 2022
@niklasad1 niklasad1 deleted the na-wasm-ci branch November 21, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants