client: feature gate tls cert store #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lexnv
approved these changes
Jan 30, 2023
niklasad1
commented
Jan 30, 2023
niklasad1
commented
Jan 30, 2023
| #[cfg(not(feature = "__tls"))] | ||
| Some("http") => Client::new(), | ||
| #[cfg(all(feature = "__tls", feature = "native-tls", feature = "webpki-tls"))] | ||
| Some("https") | Some("http") => { |
There was a problem hiding this comment.
for simplicity, just use connector based on the feature flag and yes the https connector is a bit slower on plain http than http connector.
jsdw
reviewed
Feb 1, 2023
| native-tls = ["hyper-rustls/native-tokio", "__tls"] | ||
| webpki-tls = ["hyper-rustls/webpki-tokio", "__tls"] | ||
|
|
||
| __tls = ["hyper-rustls"] |
There was a problem hiding this comment.
I'm happy with this for clarity, but just noting that as it stands, hyper-rustlswill automatically be bought in when native-tls or webpki-tls is enabled without needing it :)
There was a problem hiding this comment.
Ah but it's useful to reference this in the code, I see!
jsdw
reviewed
Feb 1, 2023
jsdw
approved these changes
Feb 1, 2023
…ate-tls-cert-store
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the clients will include dependencies for both
webpkiandnativecertificate store which can be configured at runtime but that leads to a bigger dependency tree.IIRC, I did it like this to avoid having "mutually exclusive feature" but I looked at the reqwest API and having these APIs behind a feature flag looks clean to me.
No default features implies -> no TLS